New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional entities for the Aqara E1 curtain motor to ZHA #108243
Merged
dmulcahey
merged 5 commits into
home-assistant:dev
from
dmulcahey:dm/zha-aqara-e1-cover-entities
Jan 31, 2024
Merged
Add additional entities for the Aqara E1 curtain motor to ZHA #108243
dmulcahey
merged 5 commits into
home-assistant:dev
from
dmulcahey:dm/zha-aqara-e1-cover-entities
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
dmulcahey
changed the title
Dm/zha aqara e1 cover entities
Add additional entities for the Aqara E1 curtain motor to ZHA
Jan 17, 2024
dmulcahey
force-pushed
the
dm/zha-aqara-e1-cover-entities
branch
2 times, most recently
from
January 30, 2024 17:08
4ee995f
to
d8c64fe
Compare
add icon and translation key for identify button remove previous inversion entity add window covering type sensor and aqara curtain motor sensors add aqara curtain motor hook lock switch add aqara curtain motor attributes zcl_init_attrs add aqara curtain motor zcl_init_attrs translations
dmulcahey
force-pushed
the
dm/zha-aqara-e1-cover-entities
branch
from
January 31, 2024 03:03
2bab913
to
aaa10f9
Compare
TheJulianJES
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This PR removes the existing inversion entity specific to the Aqara E1 curtain motor in favor of the standard invert switch added in #108238
Proposed change
This PR adds entities for the Aqara E1 curtain motor.
depends on #108238
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: