Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional entities for the Aqara E1 curtain motor to ZHA #108243

Merged

Conversation

dmulcahey
Copy link
Contributor

@dmulcahey dmulcahey commented Jan 17, 2024

Breaking change

This PR removes the existing inversion entity specific to the Aqara E1 curtain motor in favor of the standard invert switch added in #108238

Proposed change

This PR adds entities for the Aqara E1 curtain motor.

depends on #108238

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dmulcahey dmulcahey changed the title Dm/zha aqara e1 cover entities Add additional entities for the Aqara E1 curtain motor to ZHA Jan 17, 2024
@dmulcahey dmulcahey force-pushed the dm/zha-aqara-e1-cover-entities branch 2 times, most recently from 4ee995f to d8c64fe Compare January 30, 2024 17:08
homeassistant/components/zha/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/zha/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/zha/sensor.py Outdated Show resolved Hide resolved
dmulcahey and others added 3 commits January 30, 2024 22:02
add icon and translation key for identify button

remove previous inversion entity

add window covering type sensor and aqara curtain motor sensors

add aqara curtain motor hook lock switch

add aqara curtain motor attributes zcl_init_attrs

add aqara curtain motor zcl_init_attrs

translations
@dmulcahey dmulcahey force-pushed the dm/zha-aqara-e1-cover-entities branch from 2bab913 to aaa10f9 Compare January 31, 2024 03:03
@dmulcahey dmulcahey marked this pull request as ready for review January 31, 2024 03:24
@dmulcahey dmulcahey merged commit ac8f555 into home-assistant:dev Jan 31, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants