Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyTado to 0.17.4 #108255

Merged
merged 1 commit into from Jan 17, 2024
Merged

Bump PyTado to 0.17.4 #108255

merged 1 commit into from Jan 17, 2024

Conversation

erwindouna
Copy link
Contributor

@erwindouna erwindouna commented Jan 17, 2024

Breaking change

Proposed change

Bump PyTado to 0.17.4. This contains a fix related to the caching issues, caused by a dict that was created outside of the constructor. This led to the object being shared between multiple instances of the class. This would cause issues on Tado's API to return accessDenied errors, since it structurally contained the wrong home ID's being sent.

Changelog: wmalgadey/PyTado@0.17.3...0.17.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @chiefdragon, mind taking a look at this pull request as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tado can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tado Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@erwindouna erwindouna marked this pull request as ready for review January 17, 2024 19:16
@joostlek joostlek changed the title PyTado bump to 17.4 PyTado bump to 0.17.4 Jan 17, 2024
@joostlek joostlek added this to the 2024.1.4 milestone Jan 17, 2024
@andyb2000
Copy link

Have just manually tested this PR (By custom_component and upping the requirements in manifest.json) and can confirm this has worked for my setup. I have 4 tado instances all configured and all 4 loaded up after a full reboot of HA-OS.

Thank you all for the fixes

@joostlek joostlek changed the title PyTado bump to 0.17.4 Bump PyTado to 0.17.4 Jan 17, 2024
@joostlek joostlek merged commit 9795670 into home-assistant:dev Jan 17, 2024
49 checks passed
@erwindouna erwindouna deleted the pytado-0-17-4 branch January 17, 2024 19:58
@erwindouna
Copy link
Contributor Author

Have just manually tested this PR (By custom_component and upping the requirements in manifest.json) and can confirm this has worked for my setup. I have 4 tado instances all configured and all 4 loaded up after a full reboot of HA-OS.

Thank you all for the fixes

Thanks for all the test work!

@ditisdirkdewit
Copy link

Thanks for quickly addressing this, appreciated!

Bre77 pushed a commit to Bre77/core that referenced this pull request Jan 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tado integration - 2024.1 gives issues with multiple tado instances
5 participants