Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests of mqtt device triggers #108318

Merged
merged 1 commit into from Feb 6, 2024
Merged

Improve tests of mqtt device triggers #108318

merged 1 commit into from Feb 6, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jan 18, 2024

Proposed change

Improve the quality of the tests of MQTT device triggers. Correct test where the type or subtype of the attached trigger differs from the type and subtype in the device automation and only is linked to the discovery_id.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant home-assistant bot marked this pull request as draft January 18, 2024 20:54
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jbouwh jbouwh changed the base branch from jbouwh-simplify-mqtt-device_trigger to dev January 18, 2024 20:57
@jbouwh jbouwh marked this pull request as ready for review January 18, 2024 20:59
@jbouwh jbouwh closed this Jan 18, 2024
@jbouwh jbouwh reopened this Jan 18, 2024
@jbouwh jbouwh marked this pull request as draft January 23, 2024 05:45
@jbouwh jbouwh marked this pull request as ready for review January 30, 2024 20:10
@emontnemery emontnemery changed the title Improve tests on mqtt device triggers Improve tests of mqtt device triggers Feb 6, 2024
@jbouwh jbouwh merged commit 6ca002a into dev Feb 6, 2024
23 checks passed
@jbouwh jbouwh deleted the mqtt-tests-device_trigger branch February 6, 2024 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants