Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yolink-api to 0.3.6 fix aiomqtt breaking changes #108555

Merged
merged 2 commits into from Jan 28, 2024

Conversation

matrixd2
Copy link
Contributor

@matrixd2 matrixd2 commented Jan 21, 2024

Proposed change

Fix aiomqtt breaking changes

YoSmart-Inc/yolink-api@v0.3.4...v0.3.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob
Copy link
Member

balloob commented Jan 21, 2024

This dependency bump fixes on a fixed version of aiomqtt by setting aiomqtt==2.0.0. This means that it will start conflicting with any other dependency that will rely on aiomqtt>=2.0.1 or higher. Please loosen the dependency.

@matrixd2
Copy link
Contributor Author

This dependency bump fixes on a fixed version of aiomqtt by setting aiomqtt==2.0.0. This means that it will start conflicting with any other dependency that will rely on aiomqtt>=2.0.1 or higher. Please loosen the dependency.

Is there any way to lock the versions of dependencies to prevent third-party library dependency updates from causing integration failures?

@matrixd2 matrixd2 changed the title Bump yolink-api to 0.3.5 fix aiomqtt breaking changes Bump yolink-api to 0.3.6 fix aiomqtt breaking changes Jan 21, 2024
@bdraco bdraco added this to the 2024.1.6 milestone Jan 21, 2024
@frenck
Copy link
Member

frenck commented Jan 21, 2024

Is there any way to lock the versions of dependencies to prevent third-party library dependency updates from causing integration failures?

You could set an upper limit on the major version, however, that makes assumptions on the versioning as well (there are many different strategies). In general, the best way to handle things like this: is ensuring it works in tests.

@DarwinData

This comment was marked as off-topic.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matrixd2 👍

I use an upper bound in my library to prevent breaking changes, as aiomqtt uses semantic versioning. The best would be to write tests as mentioned by @frenck

@matrixd2
Copy link
Contributor Author

When will this fix be released? This error will cause a large number of client reconnections. In addition to users being unable to use it normally, it will also occupy a large number of server connections.

@balloob
Copy link
Member

balloob commented Jan 28, 2024

@matrixd2 I didn't realize that you bumped the dependency and have resolved my comment. This looks good.

@balloob balloob merged commit 4001062 into home-assistant:dev Jan 28, 2024
70 of 71 checks passed
Bre77 pushed a commit to Bre77/core that referenced this pull request Jan 28, 2024
…#108555)

* bump yolink-api to 0.3.5

* bump yolink-api to 0.3.6
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants