New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zhimi.airp.mb5a to xiaomi_miio integration #108593
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@rytilahti could I ask you to release a new version of the Unfortunately, due to the specifics of the script implementation in Support for As a result, without releasing an updated version of the |
I will prepare a new dev release (0.6.0.dev0) tonight, if there is nothing so serious that it would block doing that. You can subscribe for notifications at rytilahti/python-miio#1808 to follow the process. It will be necessary to make several changes in the xiaomi_miio integration to work with the restructured library (there are breaking), so those needs to be done before this specific PR can be merged. edit: release available on pypi: https://github.com/rytilahti/python-miio/releases/tag/0.6.0.dev0 - note that this is just a dev release to make it easier to port the integration over as there are breaking API changes, so this PR will have to wait until that's done. |
I'm setting this to draft since the PR is waiting for changes to |
This addon from HACS works :) |
Proposed change
Add support for
zhimi.airp.mb5a
to the Xiaomi Miio integration. This device is, at least from an interface perspective, identical to thezhimi.airp.mb5
.Note that this will have to wait for a new release of python-miio, since this depends on the changes in rytilahti/python-miio#1527.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: