Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LeaOne integration #108617

Merged
merged 6 commits into from Jan 24, 2024
Merged

Add LeaOne integration #108617

merged 6 commits into from Jan 24, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 21, 2024

Proposed change

LeoOne produces Bluetooth scales under the Xiaogui and BAGAIL brands (and probably a lot more I haven't discovered yet)

Note that auto discovery is not possible with these devices because they do not use any of the standard matching we currently support. They must be added via user flow.

https://apps.apple.com/us/app/lea-one/id1548074823

https://github.com/Bluetooth-Devices/leaone-ble/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review January 21, 2024 23:50
Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@bdraco
Copy link
Member Author

bdraco commented Jan 24, 2024

thanks

@bdraco bdraco merged commit 21f646c into dev Jan 24, 2024
53 checks passed
@bdraco bdraco deleted the leaone branch January 24, 2024 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants