Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend config entry update/abort helper to also update unique id #108681

Merged
merged 3 commits into from Jan 22, 2024
Merged

Extend config entry update/abort helper to also update unique id #108681

merged 3 commits into from Jan 22, 2024

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 22, 2024

Proposed change

Extend the new config entry update/abort helper to also be able to update the unique id as this seems to be common case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jpbede jpbede requested a review from a team as a code owner January 22, 2024 21:24
@home-assistant home-assistant bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Jan 22, 2024
@jpbede jpbede merged commit 0b79504 into home-assistant:dev Jan 22, 2024
49 checks passed
@jpbede jpbede deleted the helper-update-unique-id branch January 22, 2024 22:02
catsmanac pushed a commit to catsmanac/ha-core-dev that referenced this pull request Jan 23, 2024
@jpbede @catsmanac
Extend config entry update/abort helper to also update unique id (hom…
710184c 
…e-assistant#108681)

* Extend config entry update/abort helper to also update unique id

* Move kwarg to end

* Make additionals kwargs only
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
cla-signed core new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpbede @bdraco