Improve tests of script trace #108717
Merged
Improve tests of script trace #108717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/helpers/test_script.py
Outdated
| if trace_element.path == "0": | ||
| return | ||
| if variables := expected_element.get("variables"): |
There was a problem hiding this comment.
Can we call trace_element.as_dict instead and just do a simple equality assertion of the trace element dict under test and the expected element? Then just parametrize the expected element.
The current code is really hard to follow.
There was a problem hiding this comment.
Yes, or potentially even better, a custom syrupy serializer so we can just use snapshots.
Let's do that in a follow-up though.
emontnemery
force-pushed
the
improve_script_trace_tests
branch
from
1661332
to
49d8866
Compare
MartinHjelmare
approved these changes
Jan 23, 2024
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
emontnemery
commented
Jan 23, 2024
emontnemery
commented
Jan 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve tests of script trace, without this PR we ignore variables in the trace of the first action
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: