New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lutron in callback #108779
Update Lutron in callback #108779
Conversation
Hey there @cdheiser, @wilburCforce, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@property | ||
def brightness(self) -> int: | ||
"""Return the brightness of the light.""" | ||
new_brightness = to_hass_level(self._lutron_device.last_level()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't call last_level you may not be getting the right value. State is easily lost in a lutron system due to how the updates flow related to scenes. I strongly discourage this approach as this has been stable for a long time now.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@wilburCforce are your concerns settled now?
Proposed change
Update Lutron in callback to increase code quality
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: