Add play/pause functionality for Vizio Smartcast media_player entities #108896
Conversation
Leverages existing pyvizio functionality. My impression is that it also works for soundbars based on exiva/Vizio_SmartCast_API#19.
The Vizio API is only capable of indicating whether the device is on or off and not whether it's playing/paused/idle. Setting assumed_state to True gives us separate Play and Pause buttons versus the (useless) merged Play/Pause button we would get otherwise.
home-assistant
bot
added
cla-signed
has-tests
integration: vizio
small-pr
|
Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Resolved conflicts and would still like to see this merged if anyone would be willing to review it. |
| @@ -159,6 +159,7 @@ def __init__( | |||
| ) | |||
| self._device = device | |||
| self._max_volume = float(device.get_max_volume()) | |||
| self._attr_assumed_state = True | |||
There was a problem hiding this comment.
Why is this changed? Is it to ensure the Play/Pause buttons always show in the frontend?
There was a problem hiding this comment.
Yes, this gives us separate play/pause buttons rather than a single dynamic button (which won't actually work correctly because the Vizio API doesn't provide a playing/paused/idle status).
Breaking change
Proposed change
Add play/pause functions to the Vizio integration. Also, treat Vizio API as "assumed_state" since all we get from it is on/off status and by doing that we get split play/pause buttons rather than a single merged button which won't really work.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: