New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary sensors to TechnoVE integration #108938
Add binary sensors to TechnoVE integration #108938
Conversation
0985e17
to
f0f0025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you locally remove both .ambr files and regenerate them? I think it generated too much
Sure, it seems like the sensors I removed in an earlier PR were still included. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
8fef320
to
4158a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Moustachauve 👍
* Add binary sensors to TechnoVE integration * Add unit tests for TechnoVE binary sensors * Implement PR feedback for TechnoVE * Limit to appropriate sensors in TechnoVE tests * Removed leftover code * Implement feedback in TechnoVE PR home-assistant#108938
* Add binary sensors to TechnoVE integration * Add unit tests for TechnoVE binary sensors * Implement PR feedback for TechnoVE * Limit to appropriate sensors in TechnoVE tests * Removed leftover code * Implement feedback in TechnoVE PR home-assistant#108938
Proposed change
This adds the binary sensors from a TechnoVE station.
Type of change
Additional information
I didn't add new unit tests because I feel like the one in sensors already cover everything. It uses the same update source and mechanism. The test "test_sensors" also tests all the entity types including the new binary sensor.
I would be very interested in suggestions on how to improve this to learn more about good testing practices in HA.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: