Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary sensors to TechnoVE integration #108938

Merged
merged 6 commits into from Jan 29, 2024

Conversation

Moustachauve
Copy link
Contributor

@Moustachauve Moustachauve commented Jan 27, 2024

Proposed change

This adds the binary sensors from a TechnoVE station.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I didn't add new unit tests because I feel like the one in sensors already cover everything. It uses the same update source and mechanism. The test "test_sensors" also tests all the entity types including the new binary sensor.

I would be very interested in suggestions on how to improve this to learn more about good testing practices in HA.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you locally remove both .ambr files and regenerate them? I think it generated too much

@Moustachauve
Copy link
Contributor Author

Can you locally remove both .ambr files and regenerate them? I think it generated too much

Sure, it seems like the sensors I removed in an earlier PR were still included.

@home-assistant home-assistant bot marked this pull request as draft January 28, 2024 13:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Moustachauve added a commit to Moustachauve/HA-core that referenced this pull request Jan 29, 2024
@Moustachauve Moustachauve marked this pull request as ready for review January 29, 2024 08:48
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Moustachauve 👍

@gjohansson-ST gjohansson-ST merged commit 91e7e5e into home-assistant:dev Jan 29, 2024
23 checks passed
@Moustachauve Moustachauve deleted the technove-binary-sensor branch January 29, 2024 18:35
chemelli74 pushed a commit to chemelli74/core that referenced this pull request Jan 29, 2024
* Add binary sensors to TechnoVE integration

* Add unit tests for TechnoVE binary sensors

* Implement PR feedback for TechnoVE

* Limit to appropriate sensors in TechnoVE tests

* Removed leftover code

* Implement feedback in TechnoVE PR home-assistant#108938
Moustachauve added a commit to Moustachauve/HA-core that referenced this pull request Jan 30, 2024
* Add binary sensors to TechnoVE integration

* Add unit tests for TechnoVE binary sensors

* Implement PR feedback for TechnoVE

* Limit to appropriate sensors in TechnoVE tests

* Removed leftover code

* Implement feedback in TechnoVE PR home-assistant#108938
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants