Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pytrafikverket to 0.3.10 #108984

Merged
merged 1 commit into from Jan 28, 2024
Merged

Bump pytrafikverket to 0.3.10 #108984

merged 1 commit into from Jan 28, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jan 27, 2024 •
edited

Proposed change

Bump pytrafikverket to 0.3.10

https://github.com/gjohansson-ST/pytrafikverket/releases/tag/0.3.10

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@MartinHjelmare MartinHjelmare marked this pull request as draft January 27, 2024 23:56
@gjohansson-ST gjohansson-ST marked this pull request as ready for review January 27, 2024 23:58
MartinHjelmare
MartinHjelmare approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit c6ffd45 into dev Jan 28, 2024
53 checks passed
@MartinHjelmare MartinHjelmare deleted the pytrafikverket-0310 branch January 28, 2024 10:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed dependency integration: trafikverket_camera integration: trafikverket_ferry integration: trafikverket_train integration: trafikverket_weatherstation Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gjohansson-ST @MartinHjelmare