Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entity naming for heatpump heatings in ViCare #109013

Merged
merged 1 commit into from Jan 28, 2024

Conversation

CFenner
Copy link
Contributor

@CFenner CFenner commented Jan 28, 2024

Proposed change

This correct the naming of energy consumption sensors for gas heating, which are also show for other heating devices (e.g. heatpump) where the description lead to confusion.
Also shortened the naming as they were now really readable in the UI. Aligned the naming of daily, monthly & yearly sensors with other sensor names.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek added this to the 2024.1.6 milestone Jan 28, 2024
@joostlek joostlek merged commit 19988b4 into home-assistant:dev Jan 28, 2024
23 checks passed
@CFenner CFenner deleted the patch-3 branch January 28, 2024 18:16
Bre77 pushed a commit to Bre77/core that referenced this pull request Jan 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration ViCare: selected source ist "heatpump" but comsumption is shown in "gas" ??
3 participants