Keep track of TimerHandles independent from event loop #109022
Conversation
home-assistant
bot
added
bugfix
cla-signed
code-quality
core
small-pr
homeassistant/helpers/event.py
Outdated
| return hass.loop.call_at(loop_time, _run_async_call_action, hass, job).cancel | ||
| handle = hass.loop.call_at(loop_time, _run_async_call_action, hass, job) | ||
| if job.cancel_on_shutdown: | ||
| hass.async_track_timer_handle(handle) |
There was a problem hiding this comment.
The upside to doing this here is that its not doing for all handles which makes it cheaper. It still means uvloop would fail in tests since async_fire_time_changed in the tests helper needs access to ._scheduled. But since its only in tests, maybe we can figure out how to access whats scheduled based on if its asyncio or uvloop in the test code
|
I'm not sure the broadcast issue is sorted out MagicStack/uvloop#540 |
|
Seems to work locally for me, I just wrote a small script and captured the UDP traffic with Wireshark: 
|
Nice. Any chance you can work on which change in uvloop made it work so we can document it in that issue and ask the op to close it ? |
Yes, I'll try it |
Okay, my bad... With |
|
MagicStack/uvloop#592 should fix the broadcast issue. Lets see if they are happy with it. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Do we want to continue with this? |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
It looks like uvloop hasn't merged anything in 8 months and needs some cython 3 fixes as well. It would be nice to use it but its not looking like its being maintained these days. |
Proposed change
Currently we're relaying on the event loop to keep track / get the scheduled TimerHandles. This could / is a problem if we consider switching to uvloop, besides the
_scheduledproperty of theasyncioevent loop is a protected property, so this may break anytime (what I don't expect to)So this PR proposes to keep track of the TimeHandles, they need to be cancelled at shutdown, on our own.
I use a
WeakSethere, so we don't have to remove the reference from the set ourselves after a TimeHandle has ended.I tried also a different solution within
uvloop(create a function to return the scheduled TimeHandlers), but lead me to other issues e.g._argsorargsweren't available for theuvloopTimeHandlers.I may have forgotten something, or it may not be the ideal solution, so I'll leave this here for comments.
With this solution the implementation ofuvloopwould be quite simple, the problem with<broadcast>described in #93173 seems to be solved. I have tried this with a small test and can send packets to the<broadcast>address without any problemsThe
<broadcast>issue within uvloop mentioned in #93173 should be solved by MagicStack/uvloop#592.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: