Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repair issue for Shelly devices with unsupported firmware #109076

Merged

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Jan 29, 2024

Breaking change

Proposed change

Due to current architecture first implementation is not reparable. This feature will be added in future.

In a future PR we will adjust the architecture of the system to have limited support for older devices which will allow updating the firmware so the repair issue can be automatically fixed in most cases. As this requires a re-architecture, this is not available in the first iteration, and we felt it was better to present a repair issue than have users have to look for a cryptic log message.

Needs home-assistant-libs/aioshelly#483 (already merged)

(follow-up of #108104)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of shelly can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign shelly Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

Tested on production, nothing blew up.

Going to get the older new in box devices out of storage and test with one of them next

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

I'm going to have to make the config entry manually since I can't add unsupported devices

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

Screenshot 2024-01-29 at 12 56 18 PM

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

Going to update the firmware in the shelly app now

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

Updated, and the device recovered and setup now

@bdraco
Copy link
Member

bdraco commented Jan 29, 2024

It looks like we need to delete the issue on successful setup as well since the issue was still there after I updated the firmware

@bdraco
Copy link
Member

bdraco commented Jan 30, 2024

I'll see if I can help finish the tests before I go to the airport.

I had created 200 phantom test devices and noticed listing issues was slow #109149

@bdraco
Copy link
Member

bdraco commented Jan 30, 2024

I'm going to take a stab at writing the tests for the sleeping devices

@bdraco
Copy link
Member

bdraco commented Jan 30, 2024

Thanks @chemelli74

@bdraco bdraco merged commit d4c91bd into home-assistant:dev Jan 30, 2024
23 checks passed
@chemelli74 chemelli74 deleted the chemelli74-shelly-firmware-unsup branch January 30, 2024 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants