Velbus Cover: Assume state for VMBxBL modules #109213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
(Older) VMBxBL modules do not support position reporting. So there is no way to find out if a cover/blind is closed or open. (Newer modules do report position.)
This patch enables assumed_state in that case, and simply reports the last action as state. This is correct in most scenario's, but not all: When a user interrupts a Close action by Stop, the assumed state will be "Closed", but the actual state is "halfway", i.e. "Open". This is only cosmetic, since assumed_state=True implies that the Down button will still be enabled.
@niobos
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: