Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore support for packages being installed from urls with fragments #109267

Merged
merged 9 commits into from Feb 1, 2024
Merged

Restore support for packages being installed from urls with fragments #109267

merged 9 commits into from Feb 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 1, 2024 •
edited

Proposed change

This is a partial revert of #107427

This was removed because it was assumed nobody was using the old zip method anymore but it turns out this was also being used for git urls with fragments in custom components. As this wasn't expected to be a breaking change, revert the removal (along with some comments and tests so we know its not only zip files) to restore support for it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Restore support for packages being installed from urls with fragments
663dd40 
This was removed in #107427 because it was assumed nobody was
using the old zip method anymore but it turns out this was
also being used for git urls with fragments in custom
components
@bdraco
Restore support for packages being installed from urls with fragments
f536db5 
This was removed in #107427 because it was assumed nobody was
using the old zip method anymore but it turns out this was
also being used for git urls with fragments in custom
components
@bdraco bdraco added this to the 2024.2.0 milestone Feb 1, 2024
@bdraco bdraco requested a review from a team as a code owner February 1, 2024 02:38
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Feb 1, 2024
bdraco
bdraco commented Feb 1, 2024
View reviewed changes
homeassistant/util/package.py Outdated Show resolved Hide resolved
bdraco
bdraco commented Feb 1, 2024
View reviewed changes
homeassistant/util/package.py Outdated Show resolved Hide resolved
bdraco
bdraco commented Feb 1, 2024
View reviewed changes
homeassistant/util/package.py Outdated Show resolved Hide resolved
@bdraco
Update homeassistant/util/package.py
8a40929
@bdraco
Restore support for packages being installed from urls with fragments
9b96475 
This was removed in #107427 because it was assumed nobody was
using the old zip method anymore but it turns out this was
also being used for git urls with fragments in custom
components
@bdraco
Merge remote-tracking branch 'upstream/restore_fragment_support' into…
c41bfe9 
… restore_fragment_support
@bdraco
pep 0508 allows # in env markers so we cannot assume # means its a fr…
f192ccb 
…agment and have to fallback
elupus
elupus approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this make sense

frenck
frenck approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 8afcd53 into dev Feb 1, 2024
53 checks passed
@frenck frenck deleted the restore_fragment_support branch February 1, 2024 07:56
frenck pushed a commit that referenced this pull request Feb 1, 2024
@bdraco @frenck
Restore support for packages being installed from urls with fragments (…
e34ebcb 
…#109267)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@elupus elupus elupus approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdraco @frenck @elupus