Add presets to Advantage Air #109485
Merged
Add presets to Advantage Air #109485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
gjohansson-ST
requested changes
Feb 4, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
bdraco
reviewed
Feb 15, 2024
bdraco
reviewed
Feb 15, 2024
bdraco
reviewed
Feb 15, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
reviewed
Feb 16, 2024
bdraco
approved these changes
Feb 16, 2024
|
LGTM. gjohansson-ST has a request changes on this one so I'll hold off merging for a few days to give him a chance to take a look first. |
gjohansson-ST
approved these changes
Feb 20, 2024
| ) | ||
| return await self.async_turn_off() | ||
| if hvac_mode == HVACMode.HEAT_COOL and self.preset_mode != ADVANTAGE_AIR_MYAUTO: | ||
| raise ServiceValidationError("Heat/Cool is not supported in this mode") |
There was a problem hiding this comment.
In a follow-up PR I think adding translations would be nice 👍
There was a problem hiding this comment.
Agreed, I also want to use _handle_coordinator_update for more platforms and values
|
I originally tried to make this change in a PR on Jul 15, 2022. Today, 586 days later, preset support has been merged. Thank you gjohansson and bdraco. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Now that Supported Features and HVAC modes are allowed to change dynamically, this PR adds presets to the Advantage Air climate entity.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: