Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reauth flow to Google Tasks #109517

Merged
merged 8 commits into from
Apr 19, 2024
Merged

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Feb 3, 2024

Proposed change

Add reauth flow to Google Tasks.

We don't have anything unique related to the todo list, so we add another scope to get the user id.

The biggest downside of this change is that we can't verify if users login with the right account at the first time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 3, 2024

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (google_tasks) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_tasks can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_tasks Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely supportive of going in this direction, and i think its fine to add the profile check going forward.

I think remaining work needed is:

  • trigger reauth in init
  • add test coverage

homeassistant/components/google_tasks/config_flow.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Feb 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 3, 2024 17:52
@joostlek
Copy link
Member Author

joostlek commented Feb 3, 2024

Yea I still need to add code coverage, but I wanted to get it out to check what we think of it

@joostlek joostlek marked this pull request as ready for review February 18, 2024 09:58
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Apr 18, 2024
@joostlek
Copy link
Member Author

Both are fixed now imo, so ready for review again

@github-actions github-actions bot removed the stale label Apr 19, 2024
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@joostlek joostlek merged commit c108c7d into home-assistant:dev Apr 19, 2024
24 checks passed
@joostlek joostlek deleted the google-tasks-reauth branch April 19, 2024 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconfigure Google Tasks
3 participants