-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reauth flow to Google Tasks #109517
Add reauth flow to Google Tasks #109517
Conversation
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely supportive of going in this direction, and i think its fine to add the profile check going forward.
I think remaining work needed is:
- trigger reauth in init
- add test coverage
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Yea I still need to add code coverage, but I wanted to get it out to check what we think of it |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Both are fixed now imo, so ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Proposed change
Add reauth flow to Google Tasks.
We don't have anything unique related to the todo list, so we add another scope to get the user id.
The biggest downside of this change is that we can't verify if users login with the right account at the first time.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: