Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Flo devices and entities from going unavailable when a single refresh fails #109522

Merged
merged 2 commits into from Feb 3, 2024

Conversation

dmulcahey
Copy link
Contributor

Proposed change

This PR buffers failures from the Flo API. It appears they do some sort of data aggregation that causes latency on their side and that makes API calls time out. This change buffers failures so that we need > 3 failures before raising an exception.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/flo/device.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

home-assistant bot commented Feb 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 3, 2024 20:21
@dmulcahey dmulcahey marked this pull request as ready for review February 3, 2024 23:26
@dmulcahey dmulcahey merged commit 63da42f into home-assistant:dev Feb 3, 2024
23 checks passed
@beausmith
Copy link

🙏 Thank you @dmulcahey !

frenck pushed a commit that referenced this pull request Feb 4, 2024
… refresh fails (#109522)

* Prevent Flo devices and entities from going unavailable when a single refresh fails

* review comment
@dmulcahey dmulcahey mentioned this pull request Feb 5, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flo by Moen integration goes offline many times per day
5 participants