Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyMicrobot to 0.0.10 #109628

Merged
merged 11 commits into from Feb 5, 2024
Merged

Bump pyMicrobot to 0.0.10 #109628

merged 11 commits into from Feb 5, 2024

Conversation

spycle
Copy link
Contributor

@spycle spycle commented Feb 4, 2024

Proposed change

The integration has recently stopped working. Where the integration is already installed, the device is always unavailable. Installing from fresh is impossible as the config flow fails at the pairing stage.

This is part 1 to get it working again.
spycle/pyMicroBot@v0.0.9...v.0.0.10

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Ensure Microbot is connected after linking
Up version PyMicroBot==0.0.10
Up version PyMicroBot==0.0.10
hassfest fail
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the PRs and when creating the PR for the config flow fix, please add unit tests since the config flow is required to have 100% coverage

@home-assistant home-assistant bot marked this pull request as draft February 4, 2024 19:46
@home-assistant
Copy link

home-assistant bot commented Feb 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Correct integration type
revert changes
revert changes
@spycle spycle changed the title Fix keymitt_ble config_flow and bump pyMicrobot Bump pyMicrobot to 0.0.10 Feb 4, 2024
@spycle spycle mentioned this pull request Feb 4, 2024
20 tasks
@spycle spycle marked this pull request as ready for review February 4, 2024 21:02
@spycle
Copy link
Contributor Author

spycle commented Feb 4, 2024

not sure how to make the CI run again

PRs have been split

@edenhaus edenhaus merged commit bfebde0 into home-assistant:dev Feb 5, 2024
53 checks passed
@thecode thecode added this to the 2024.2.0 milestone Feb 5, 2024
frenck pushed a commit that referenced this pull request Feb 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants