New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable energy report based operations with API lib upgrade #109832
Disable energy report based operations with API lib upgrade #109832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @vilppuvuorinen 👍
This is a breaking change, so let's write some text for the end-user in the breaking change section of the PR (which will be used for the release notes).
We should also clean up the sensors for this. If we keep them, they will be stale/orphaned basically. So, let's remove the call and the sensor descriptions for these.
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I've taken the liberty to make the adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but could use a second pair of eyes, as I made adjustments too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Franck Nijhof <git@frenck.dev>
Breaking change
The daily energy sensors have been removed to prevent being throttled by the external API. This mostly affects ATW devices.
For ATA devices this sensor is also removed, however, the total energy consumed (if your device supports that), remains available. The latter supports long-term statistics, which also provides insights into daily energy usage via the energy dashboard or using statistic card.
Proposed change
Upgrade pymelcloud to remove energy report based operations. This change breaks daily energy consumption for ATW devices, but help prevent throttling. The API lib returns always
None
now which is a valid return value according to the existing type annotations. See commit for details vilppuvuorinen/pymelcloud@a4a586aChangelog: https://github.com/vilppuvuorinen/pymelcloud/blob/v2.5.x/CHANGELOG.md#259---2024-02-06
vilppuvuorinen/pymelcloud@8756c36...33a827b
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: