Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylutron to 0.2.11 #109853

Merged
merged 2 commits into from Feb 8, 2024
Merged

Conversation

wilburCforce
Copy link
Contributor

@wilburCforce wilburCforce commented Feb 7, 2024

Proposed change

Update pylutron to 0.2.11 which adds support for transition times and flashing on Lutron outputs (Home Assistant Lights)

The pylutron PR for transition times can be found here:
thecynic/pylutron#87

The release notes for the version are here:
https://github.com/thecynic/pylutron/releases/tag/0.2.11

Changes to support flashing can be found here:
thecynic/pylutron@6ef9dc5

Github diff is here: thecynic/pylutron@054b29e...0.2.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 7, 2024

Hey there @cdheiser, mind taking a look at this pull request as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign lutron Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@wilburCforce wilburCforce marked this pull request as ready for review February 7, 2024 06:18
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff in the description shows the changes between 2.9.0 and 0.2.11, but we are updating from 0.2.8.
Please add the diff from that version.

@home-assistant home-assistant bot marked this pull request as draft February 7, 2024 08:06
@home-assistant
Copy link

home-assistant bot commented Feb 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@wilburCforce
Copy link
Contributor Author

The diff in the description shows the changes between 2.9.0 and 0.2.11, but we are updating from 0.2.8. Please add the diff from that version.

The pylutron repo doesn't have releases or tags prior to 2.9.0. I've replaced the starting point with the commit closest to the 2.8 release to account for that. It might be one commit earlier but will contain all the changes.

@wilburCforce wilburCforce marked this pull request as ready for review February 8, 2024 04:18
@edenhaus
Copy link
Contributor

edenhaus commented Feb 8, 2024

test failure unrelated

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wilburCforce 👍

@edenhaus edenhaus merged commit 29d3e17 into home-assistant:dev Feb 8, 2024
48 of 49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
@frenck frenck added this to the 2024.2.2 milestone Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants