Add snapshot service to image entity #110057
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
NickM-27
force-pushed
the
image-service
branch
from
68ebd70
to
4a9164c
Compare
NickM-27
force-pushed
the
image-service
branch
2 times, most recently
from
ae0cdba
to
1cf1e69
Compare
NickM-27
force-pushed
the
image-service
branch
from
7845a05
to
e1c12c9
Compare
|
@NickM-27 There are merge conflicts, can you please merge or rebase the PR? |
NickM-27
force-pushed
the
image-service
branch
from
4174078
to
558cb35
Compare
|
@emontnemery thanks, rebased 👍 |
frenck
added
the
smash
|
looks like the failing tests are unrelated to these changes |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| fields: | ||
| filename: | ||
| required: true | ||
| example: "/tmp/snapshot_{{ entity_id.name }}.jpg" |
There was a problem hiding this comment.
The examples need to be updated for the new variables
There was a problem hiding this comment.
because it was corrected to have the entity id instead of the entity or something else?
| @@ -354,3 +357,111 @@ async def _wrap_async_get_still_stream(*args, **kwargs): | |||
| await hass.async_block_till_done() | |||
|
|
|||
| await close_future | |||
|
|
|||
There was a problem hiding this comment.
How about adding a test that exercises the entity template variables?
There was a problem hiding this comment.
Sorry, can you elaborate? I am not 100% sure what you mean by that
There was a problem hiding this comment.
Add a test case that in the template references the variables that are used in the examples.
There was a problem hiding this comment.
Like add a test that uses a filename of /tmp/snapshot_{{ entity_id.name }}.jpg
Proposed change
Integrations are moving from using the camera.entity to image.entity but there is not feature parity when it comes to the services offered for the image.entity. This PR adds the snapshot service to the image entity so users are able to save the images offline for their own usage.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: