Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tradfri tests #110094

Merged
merged 4 commits into from Feb 11, 2024
Merged

Refactor tradfri tests #110094

merged 4 commits into from Feb 11, 2024

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Feb 9, 2024

Breaking change

Proposed change

  • Refactor the tradfri tests to not depend on integration details and make it easier to update the integration and library in the future.
  • Most platforms had already been refactor previously except the light platform. To be able to finish the refactor of the light platform tests, a further refactor of the API command handling of the tests was done. The light platform can send more than a single command per service call, which required us to be able to detect more than the last sent command to calculate an appropriate state response.
  • Since the library has a sans-io design, many of the mocks could be removed, after this refactor.
  • The config flow tests haven't been touched in this PR. That will be done separately.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

state[key] = modify_state(state[key], value)
else:
state[key] = value
def register_device(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this become methods on the CommandStore ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the CommandStore already be initialized with the gateway too ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the functions that used the command store to the command store as methods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command store is required by the gateway fixture, so it will always be initialized together with the mock gateway.

@MartinHjelmare MartinHjelmare merged commit 6b4920f into dev Feb 11, 2024
23 checks passed
@MartinHjelmare MartinHjelmare deleted the refactor-tradfri-light-tests branch February 11, 2024 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants