Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up bootstrap by preloading manifests for base platforms #110130

Merged
merged 10 commits into from Feb 16, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 9, 2024

Will conflict with #110136 This one should merge first

With the combination of the two my large installs are now initializing in ~14-16s consistently

Proposed change

Speed up bootstrap by preloading manifests for base platforms

#107312 did a lot to reduce executor jobs at startup, but we still ended up with a single job per base platform. By loading them earlier we reduce lock contention and executor jobs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review February 9, 2024 22:48
@bdraco bdraco requested a review from a team as a code owner February 9, 2024 22:48
@bdraco bdraco marked this pull request as draft February 11, 2024 03:33
@bdraco bdraco marked this pull request as ready for review February 11, 2024 03:40
homeassistant/bootstrap.py Show resolved Hide resolved
homeassistant/bootstrap.py Show resolved Hide resolved
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Feb 16, 2024

thanks

@bdraco bdraco merged commit 1260c5a into dev Feb 16, 2024
53 checks passed
@bdraco bdraco deleted the bootstrap_opt branch February 16, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants