New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old BMW vehicles/devices automatically #110255
Conversation
Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
3424d00
to
a9d173a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test.
Example:
core/tests/components/tradfri/test_init.py
Lines 49 to 92 in 7dc9ad6
async def test_remove_stale_devices( | |
hass: HomeAssistant, | |
device_registry: dr.DeviceRegistry, | |
) -> None: | |
"""Test remove stale device registry entries.""" | |
config_entry = MockConfigEntry( | |
domain=tradfri.DOMAIN, | |
data={ | |
tradfri.CONF_HOST: "mock-host", | |
tradfri.CONF_IDENTITY: "mock-identity", | |
tradfri.CONF_KEY: "mock-key", | |
tradfri.CONF_GATEWAY_ID: GATEWAY_ID, | |
}, | |
) | |
config_entry.add_to_hass(hass) | |
device_registry.async_get_or_create( | |
config_entry_id=config_entry.entry_id, | |
identifiers={(tradfri.DOMAIN, "stale_device_id")}, | |
) | |
device_entries = dr.async_entries_for_config_entry( | |
device_registry, config_entry.entry_id | |
) | |
assert len(device_entries) == 1 | |
device_entry = device_entries[0] | |
assert device_entry.identifiers == {(tradfri.DOMAIN, "stale_device_id")} | |
await hass.config_entries.async_setup(config_entry.entry_id) | |
await hass.async_block_till_done() | |
device_entries = dr.async_entries_for_config_entry( | |
device_registry, config_entry.entry_id | |
) | |
# Check that only the gateway device entry remains. | |
assert len(device_entries) == 1 | |
device_entry = device_entries[0] | |
assert device_entry.identifiers == { | |
(tradfri.DOMAIN, config_entry.data[tradfri.CONF_GATEWAY_ID]) | |
} | |
assert device_entry.manufacturer == "IKEA of Sweden" | |
assert device_entry.name == "Gateway" | |
assert device_entry.model == "E1526" |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thanks! |
Proposed change
This PR enables removal of old devices and their entities usingasync_remove_config_entry_device()
if the vehicle is not active anymore.This PR adjust loading the config entry and deletes vehicles not assigned to the BMW account from the DeviceRegistry.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: