Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no data error in Electricity Maps config flow #110259

Merged
merged 2 commits into from Feb 12, 2024

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Feb 11, 2024

Proposed change

The Electricity Maps can respond with {"status": "no-data", ...}, which means that no data is available for the selected region. The upstream lib raises a ElectricityMapsNoDataError in this case. This PR deals with this in the config flow.

Also remove api_ratelimit from strings.json, which is not needed anymore.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @VIKTORVAV99, mind taking a look at this pull request as it has been labeled with an integration (co2signal) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of co2signal can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign co2signal Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny suggestion otherwise things look good from my side.

homeassistant/components/co2signal/strings.json Outdated Show resolved Hide resolved
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
@lellky
Copy link
Contributor

lellky commented Feb 11, 2024

In the PR description it says "status=no-data" but in the code it says "no_data": "No data is provided for the location you have selected.". Do you mean in the PR description "status=no_data"?

@jpbede
Copy link
Member Author

jpbede commented Feb 11, 2024

No that is right, the PR is confusing yes, the API returns {"status": "no-data", ...}, the lib throws than a error. This PR deals with this error.

Copy link
Contributor

@lellky lellky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jpbede jpbede added this to the 2024.2.2 milestone Feb 11, 2024
Copy link
Contributor

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edenhaus edenhaus merged commit fb87883 into home-assistant:dev Feb 12, 2024
23 checks passed
@jpbede jpbede deleted the co2signal-handle-no-data-error branch February 12, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants