New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle no data error in Electricity Maps config flow #110259
Handle no data error in Electricity Maps config flow #110259
Conversation
Hey there @VIKTORVAV99, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one tiny suggestion otherwise things look good from my side.
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
In the PR description it says "status=no-data" but in the code it says |
No that is right, the PR is confusing yes, the API returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed change
The Electricity Maps can respond with
{"status": "no-data", ...}
, which means that no data is available for the selected region. The upstream lib raises aElectricityMapsNoDataError
in this case. This PR deals with this in the config flow.Also remove
api_ratelimit
fromstrings.json
, which is not needed anymore.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: