Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor platform for husqvarna_automower #110410

Merged
merged 12 commits into from Feb 22, 2024

Conversation

Thomas55555
Copy link
Contributor

@Thomas55555 Thomas55555 commented Feb 12, 2024

Breaking change

Proposed change

Add the following sensors to the Husqvarna Automower integration:

  • Battery level
  • Number of charging cycles
  • Number of collisions
  • Cutting blade usage time
  • Total charging time
  • Total cutting time
  • Total running time
  • Total searching time
  • Total drive distance
  • Next start
  • Mode

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/husqvarna_automower/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/husqvarna_automower/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/husqvarna_automower/strings.json Outdated Show resolved Hide resolved
@Thomas55555 Thomas55555 marked this pull request as ready for review February 20, 2024 17:06
@MartinHjelmare MartinHjelmare marked this pull request as draft February 21, 2024 11:19
…istinguish the entity description parameters from the lambda
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 6e91776 into home-assistant:dev Feb 22, 2024
23 checks passed
Lektrico pushed a commit to Lektrico/core that referenced this pull request Feb 22, 2024
* Add sensor platform for husqvarna_automower

* Adress review comments

* Try to fix test

* Improve sensors

* Address review

* Adapt some values

* Add test

* Add test for cutting blade usage time

* Import TEST_MOWER_ID

* Use a parenthesis around the lambda and indent it so it's easier to distinguish the entity description parameters from the lambda
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@Thomas55555 Thomas55555 deleted the add-sensor-platform branch March 13, 2024 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants