Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate session closed error in Netgear LTE #110412

Merged
merged 1 commit into from Feb 16, 2024

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Feb 12, 2024

Proposed change

Before this PR, a number of users have reported issues with the aiohttp ClientSession being closed with no way to fix via reload. They would have to resort to restarting Home Assistant which did not always work. On all 3 of my Mac, production NUC running Supervised, and Home Assistant Blue, this was never an issue for me. Only when the Mac was under heavy load, would it possibly fail and even then it was not consistently failing. This PR should now enable impacted users to reload the integration either manually or with the homeassistant.reload_config_entry service in an automation for the time being.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkdrob 👍

@edenhaus edenhaus merged commit 2ac7d11 into home-assistant:dev Feb 16, 2024
23 checks passed
@edenhaus edenhaus added this to the 2024.2.2 milestone Feb 16, 2024
@tkdrob tkdrob deleted the netgear_lte_session branch February 16, 2024 11:26
@frenck frenck mentioned this pull request Feb 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants