New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some myuplink tests #110521
Add some myuplink tests #110521
Conversation
Hey there @pajzo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I have broken out the fixture loading with session scope. But I don't get exactly what you mean by the second paragraph. Can you give a little example? PS I messed up my branch in #110426 and i found it easiest to close and start over with this PR. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Thank you for the assistance. Setting up the tests is a bit outside my comfort zone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the fixtures that return strings should be marked as scope session. The fixtures that return mutable objects should be scoped per test so we can modify the fixture data without risking affecting other tests.
I think I am starting to understand the background... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you @MartinHjelmare, I have learned a lot during this review and I hope that we soon will see more thorough tests for this integration. |
Breaking change
Proposed change
Add some more test to myuplink.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: