New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add myuplink reauth flow #110587
Add myuplink reauth flow #110587
Conversation
Hey there @pajzo, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Well, it is cleaned up and tests work except that the scope is not updated because the abort-and-reload is not executed. Real HA works fine.
|
I think we are getting close! |
CI is failing on file test_ini.py. It was removed as per your request in this latest commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks again for your thorough and constructive review. |
Breaking change
Proposed change
Add reauth flow
Before we release the switch platform and other future platforms that send commands to the API we need to add a "WRITESYSTEM" scope to OAuth2 .
There is now a check for this scope in async_setup_entry(). If the scope is missing a reauthentication flow is initiated. The user will have to authenticate the account at myUplink and after a few clicks it is finished and the integration starts again.
TODO
The reauth flow should also be triggered by normal HTTP authentication errors but that is a topic for a follow-up PR.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: