New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump libpyfoscam to 1.2.2 #110625
Bump libpyfoscam to 1.2.2 #110625
Conversation
Hey there @skgsergio, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This dependency update will be used in #109491 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
That diff is to master, not to 1.2.2. Please set it to the right commit so the diff stays correct in the future. |
Breaking change
Proposed change
Update libpyfoscam from 1.0 to 1.2.2:
krmarien/python-foscam@1.0...v1.2.2
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: