New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deebot-client to 5.2.1 #110683
Bump deebot-client to 5.2.1 #110683
Conversation
Hey there @OverloadUT, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In DeebotUniverse/client.py#419 you removed some properties of the ApiDeviceInfo
also the deviceName
, which is used in
core/homeassistant/components/ecovacs/entity.py
Lines 58 to 59 in f458ccc
if model := device_info.api_device_info.get("deviceName"): | |
info["model"] = model |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @edenhaus 👍
* Bump deebot-client to 5.2.0 * Bumb again * Fix tests
Breaking change
Proposed change
Release:
Diff: DeebotUniverse/client.py@5.1.1...5.2.1
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: