Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derivative integration sample leave time window #110689

Conversation

FlorianOosterhof
Copy link
Contributor

Proposed change

This change fixes a bug where the Derivative integration with Simple-Moving-Average behaviour would not reset the value to 0 after there are no more state changes within the averaging window: If there are no state changes in the window, then a single state (value) encompasses the entire window and thus the averaged derivative is 0.

However, more generally, this change updates the Derivative integration sensor every time a state change that has entered the window leaves the window.

The code is mostly copied from Statistics integration, but adapted to the requirements of the Derivative integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @afaucogney, mind taking a look at this pull request as it has been labeled with an integration (derivative) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of derivative can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign derivative Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@FlorianOosterhof FlorianOosterhof force-pushed the bugfix-derivative-integration-sample-leave-time-window branch from 634d51a to 3f8495e Compare February 15, 2024 23:45
@MartinHjelmare MartinHjelmare changed the title Bugfix derivative integration sample leave time window Fix derivative integration sample leave time window Feb 16, 2024
@FlorianOosterhof FlorianOosterhof force-pushed the bugfix-derivative-integration-sample-leave-time-window branch from 3f8495e to 1e5ad3b Compare February 26, 2024 20:58
@FlorianOosterhof FlorianOosterhof force-pushed the bugfix-derivative-integration-sample-leave-time-window branch from 1e5ad3b to 63d3b60 Compare February 27, 2024 19:19
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Apr 27, 2024
@github-actions github-actions bot closed this May 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant