Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matplotlib pinning due to Python 3.12 incompatibility #110706

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

sbyx
Copy link
Contributor

@sbyx sbyx commented Feb 16, 2024

Proposed change

Remove the pinning from matplotlib as the pinned version seems to be incompatible after the upgrade to Python 3.12. The current pinning breaks all kinds of e.g. custom components that depend on matplotlib as it prevents matplotlib from being installed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Feb 16, 2024
@edenhaus edenhaus changed the title Remove matplotlib pinning due to Python 3.12 incompatibility (fixes #109961) Remove matplotlib pinning due to Python 3.12 incompatibility Feb 16, 2024
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 5d0d3a5 into home-assistant:dev Feb 16, 2024
53 checks passed
@sbyx
Copy link
Contributor Author

sbyx commented Feb 16, 2024

Thank you!

@tmjo
Copy link

tmjo commented Feb 16, 2024

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after upgrade to 2024.2 the 'matplotlib>=3.4.2' not found
4 participants