Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local todo list persistence for due dates #110830

Merged
merged 3 commits into from Feb 18, 2024

Conversation

allenporter
Copy link
Contributor

Proposed change

Fix how local todo list handles of due dates when persisted to disk. In rfc5545, the due date field is exclusive and at midnight on the due date a task is considered overdue, equivalent to end dates on a calendar event where all day events have a duration of one day. Home Assistant is using inclusive dates for due dates so a task is not considered overdue until the next day (consistent with how APIs like Google Tasks or Todoist represent a due date)

This PR has two main changes:
(1) Handle converting between the home assistant due date format (inclusive dates) and the persisted due date format
(2) Migrate old calendar object files to the new todo format.

This is needed to prepare for handle recurring tasks correctly where only one instance of a specific task is shown at a time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit babb436 into home-assistant:dev Feb 18, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants