Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tessie tests #110980

Merged
merged 3 commits into from Feb 20, 2024
Merged

Fix failing tessie tests #110980

merged 3 commits into from Feb 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 19, 2024

Proposed change

There was a midair collision with merges so the snapshots needed to be regenerated.

I also added a rewrite so if these tests fail they will not show the failure instead of an AssertionError

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If these tests fail they will not show anything other than
AssertionError without the rewrite

they are currently failing in #110978
and I have not been able to find the cause
@home-assistant
Copy link

Hey there @Bre77, mind taking a look at this pull request as it has been labeled with an integration (tessie) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tessie can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tessie Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco changed the title Fix pytest assertions from tessie test common Fix failing tessie tests Feb 20, 2024
@bdraco
Copy link
Member Author

bdraco commented Feb 20, 2024

Thanks 🙇

@bdraco bdraco merged commit 015f9cd into dev Feb 20, 2024
23 checks passed
@bdraco bdraco deleted the tessie_fix_assertions branch February 20, 2024 02:45
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants