Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vital 100S & Vital 200S to VeSync sensors #111017

Merged
merged 2 commits into from Feb 21, 2024

Conversation

jkossis
Copy link
Contributor

@jkossis jkossis commented Feb 20, 2024

Breaking change

Proposed change

This change adds sensor capabilities for both Vital100S and Vital200S

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]

This comment was marked as resolved.

@home-assistant home-assistant bot marked this pull request as draft February 20, 2024 14:52
@home-assistant

This comment was marked as resolved.

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @cdnninja, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot]

This comment was marked as resolved.

home-assistant[bot]

This comment was marked as resolved.

@jkossis
Copy link
Contributor Author

jkossis commented Feb 20, 2024

@cdnninja I see that you have been active in here recently, any chance I could get a glance at this?

@MartinHjelmare MartinHjelmare changed the title Adding vital100s & vital200s to VeSync sensors Add vital100s & vital200s to VeSync sensors Feb 20, 2024
@TheJulianJES
Copy link
Contributor

TheJulianJES commented Feb 20, 2024

I think the new devices should also be added to the docs:

Open a PR with the updates against the next branch and link it here when you're done.

@jkossis
Copy link
Contributor Author

jkossis commented Feb 21, 2024

@TheJulianJES here is the docs change that you requested: home-assistant/home-assistant.io#31529

@TheJulianJES TheJulianJES changed the title Add vital100s & vital200s to VeSync sensors Add Vital 100S & Vital 200S to VeSync sensors Feb 21, 2024
@TheJulianJES TheJulianJES merged commit a5ab2df into home-assistant:dev Feb 21, 2024
23 checks passed
@jkossis jkossis deleted the add-vital-sensors branch February 22, 2024 12:26
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants