New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vital 100S & Vital 200S to VeSync sensors #111017
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey there @markperdue, @webdjoe, @TheGardenMonkey, @cdnninja, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
730aa35
to
50b2227
Compare
@cdnninja I see that you have been active in here recently, any chance I could get a glance at this? |
I think the new devices should also be added to the docs:
Open a PR with the updates against the |
@TheJulianJES here is the docs change that you requested: home-assistant/home-assistant.io#31529 |
Breaking change
Proposed change
This change adds sensor capabilities for both Vital100S and Vital200S
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: