Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide users to migrate from Ubiquiti Cloud Accounts to local for UniFi Protect #111018

Merged
merged 12 commits into from Feb 21, 2024

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Feb 20, 2024

Proposed change

Starting on July 22nd, 2024, Ubiquiti will require all cloud users to enroll in multi-factor authentication (MFA). Ubiquiti Cloud SSO accounts can no longer be used for the Protect integration. Affected users will be issued a repair to migrate to a local only account to use to login with the Protect integration as the documentation expects. This PR blocks new config entries and re-auth attempts from using Cloud accounts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@AngellusMortis AngellusMortis marked this pull request as draft February 20, 2024 15:40
@AngellusMortis AngellusMortis marked this pull request as ready for review February 20, 2024 16:26
Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco bdraco changed the title Block Ubiquiti Cloud Accounts for UniFi Protect Guide users to migrate from Ubiquiti Cloud Accounts to local for UniFi Protect Feb 20, 2024
homeassistant/components/unifiprotect/strings.json Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 20, 2024 17:30
@AngellusMortis AngellusMortis marked this pull request as ready for review February 20, 2024 17:57
@joostlek joostlek dismissed their stale review February 20, 2024 17:59

Changes implemented

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Feb 21, 2024
@bdraco bdraco merged commit 7eb6614 into home-assistant:dev Feb 21, 2024
23 checks passed
@bdraco bdraco deleted the block-cloud branch February 21, 2024 05:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: unifiprotect Quality Scale: platinum small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants