Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump georss-qld-bushfire-alert-client to 0.7 #111075

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Feb 21, 2024

Proposed change

Bump georss-qld-bushfire-alert-client to 0.7

This version comes with some code quality improvements and Python 3.12 support.
I had to slightly modify the unit tests because after I refactored the file structure of classes in the library, mocking the update method of QldBushfireAlertFeed did not work anymore, hence I had to fall back to mocking the method where it is actually defined in the super class GeoRssFeed.

Changelog: https://github.com/exxamalte/python-georss-qld-bushfire-alert-client/blob/master/CHANGELOG.md
Diff: exxamalte/python-georss-qld-bushfire-alert-client@v0.5...v0.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 5f9d462 into home-assistant:dev Feb 22, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@exxamalte exxamalte deleted the bump-georss-qld-bushfire-alert-client branch February 24, 2024 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants