Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Bluetooth coordinators to use Debouncer async_schedule_call #111077

Merged
merged 4 commits into from Feb 22, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 21, 2024

Proposed change

If the debouncer does not fire the underlying call no task has to be scheduled

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the debouncer does not fire the underlying call no task has to be
scheduled
@bdraco
Copy link
Member Author

bdraco commented Feb 21, 2024

The test for the discovery needs some cleanup. Probably should split the init change into a separate PR as that's really a whole different area

@bdraco bdraco changed the title Switch Bluetooth to use Debouncer async_schedule_call Migrte Bluetooth coordinators to use Debouncer async_schedule_call Feb 21, 2024
@joostlek joostlek changed the title Migrte Bluetooth coordinators to use Debouncer async_schedule_call Migrate Bluetooth coordinators to use Debouncer async_schedule_call Feb 21, 2024
@bdraco bdraco marked this pull request as ready for review February 21, 2024 15:02
@balloob balloob merged commit e88dfd4 into dev Feb 22, 2024
53 checks passed
@balloob balloob deleted the bluetooth_async_call branch February 22, 2024 03:03
@bdraco
Copy link
Member Author

bdraco commented Feb 22, 2024

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants