Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entities for Balboa Spa pumps #111245

Merged
merged 3 commits into from Feb 28, 2024
Merged

Conversation

snoack
Copy link
Contributor

@snoack snoack commented Feb 23, 2024

Proposed change

The Balboa Spa integration was missing entities to control the pumps (for the jets) of the Hot Tub. This PR is adding entities for the pumps. As requested this was split out of #111222 to limit the scope.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
    • (Do I need to bother running tests locally, or will they run when I submit this PR automatically?)
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @garbled1, @natekspencer, mind taking a look at this pull request as it has been labeled with an integration (balboa) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of balboa can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign balboa Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing, could you please have a look 👍

@home-assistant home-assistant bot marked this pull request as draft February 24, 2024 19:12
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@snoack snoack marked this pull request as ready for review February 24, 2024 20:30
@home-assistant home-assistant bot requested a review from jpbede February 24, 2024 20:30
@snoack
Copy link
Contributor Author

snoack commented Feb 24, 2024

Updated the branch, this hopefully fixes the issues on the CI.

homeassistant/components/balboa/fan.py Outdated Show resolved Hide resolved
homeassistant/components/balboa/fan.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft February 24, 2024 21:58
@snoack snoack force-pushed the balboa-pumps branch 2 times, most recently from 5461ec2 to 3760c82 Compare February 25, 2024 15:38
@snoack snoack marked this pull request as ready for review February 25, 2024 15:40
@home-assistant home-assistant bot requested a review from jpbede February 25, 2024 15:40
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test, than this good to go

@snoack
Copy link
Contributor Author

snoack commented Feb 26, 2024

Does it matter that there are no existing tests for this component?

@jpbede
Copy link
Member

jpbede commented Feb 26, 2024

Well, the integration has a nearly 100% test coverage which we would break without a test. So I would encourage you to add one.

@snoack
Copy link
Contributor Author

snoack commented Feb 26, 2024

You are right, I didn't find the tests initially.

@snoack
Copy link
Contributor Author

snoack commented Feb 28, 2024

I had a go but not sure if the test works. I couldn't get the tests to run locally. I keep getting AttributeError: module 'homeassistant.components' has no attribute 'zeroconf' when running tests for this component (even without my changes here)?

@jpbede
Copy link
Member

jpbede commented Feb 28, 2024

I hope you don't mind me fixing the test for you, that would have been too much for comments I think. So feel free to have a look and apply it to your other PR when this one is merged 🙂 .

@jpbede jpbede merged commit 5a57816 into home-assistant:dev Feb 28, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants