New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entities for Balboa Spa pumps #111245
Conversation
Hey there @garbled1, @natekspencer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
dd6fbfb
to
35e5fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing, could you please have a look 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Updated the branch, this hopefully fixes the issues on the CI. |
5461ec2
to
3760c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test, than this good to go
Does it matter that there are no existing tests for this component? |
Well, the integration has a nearly 100% test coverage which we would break without a test. So I would encourage you to add one. |
You are right, I didn't find the tests initially. |
I had a go but not sure if the test works. I couldn't get the tests to run locally. I keep getting |
I hope you don't mind me fixing the test for you, that would have been too much for comments I think. So feel free to have a look and apply it to your other PR when this one is merged 🙂 . |
Proposed change
The Balboa Spa integration was missing entities to control the pumps (for the jets) of the Hot Tub. This PR is adding entities for the pumps. As requested this was split out of #111222 to limit the scope.
Type of change
Additional information
This PR fixes or closes issue: fixes #This PR is related to issue:Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: