Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opower to 0.3.1 #111307

Merged
merged 1 commit into from Feb 24, 2024
Merged

Bump opower to 0.3.1 #111307

merged 1 commit into from Feb 24, 2024

Conversation

benhoff
Copy link
Contributor

@benhoff benhoff commented Feb 24, 2024

Proposed change

Bump opower instance, diff located here: tronikos/opower@b1b67e7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benhoff

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft February 24, 2024 18:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek
Copy link
Member

Please run python -m script.hassfest

Also

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@benhoff
Copy link
Contributor Author

benhoff commented Feb 24, 2024

Here's a diff between the two versions:

tronikos/opower@b1b67e7

Hassfest is throwing errors for me.

@benhoff
Copy link
Contributor Author

benhoff commented Feb 24, 2024

Got hassfest working:

(venv) [hoff@princess core]$ python -m script.hassfest
Validating application_credentials... done in 0.01s
Validating bluetooth... done in 0.01s
Validating codeowners... done in 0.01s
Validating config_schema... done in 0.68s
Validating dependencies... done in 2.22s
Validating dhcp... done in 0.01s
Validating icons... done in 0.05s
Validating json... done in 0.00s
Validating manifest... done in 0.05s
Validating mqtt... done in 0.01s
Validating requirements... done in 0.01s
Validating services... done in 0.87s
Validating ssdp... done in 0.01s
Validating translations... done in 2.96s
Validating usb... done in 0.01s
Validating zeroconf... done in 0.01s
Validating config_flow... done in 0.06s
Validating coverage... done in 0.03s
Validating docker... done in 0.00s
Validating mypy_config... done in 0.01s
Validating metadata... done in 0.00s

Integrations: 1247
Invalid integrations: 0

@benhoff benhoff marked this pull request as ready for review February 24, 2024 19:47
@joostlek
Copy link
Member

Please put the diff in the PR description

@joostlek joostlek changed the title bump opower version Bump opower to 0.3.1 Feb 24, 2024
@benhoff
Copy link
Contributor Author

benhoff commented Feb 24, 2024

Please put the diff in the PR description

added

@joostlek joostlek added this to the 2024.2.4 milestone Feb 24, 2024
@joostlek joostlek merged commit adf4392 into home-assistant:dev Feb 24, 2024
48 of 49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants