Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch nmap_tracker to use aiooui #111415

Merged
merged 1 commit into from Feb 26, 2024
Merged

Switch nmap_tracker to use aiooui #111415

merged 1 commit into from Feb 26, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 25, 2024

Proposed change

mac-vendor-lookup can take a long time to startup because it has to fetch the oui db from the web. Additional we likely won't have to wait for the database to be loaded from disk since its a single source which is shared between some other integrations already using this (including bluetooth)

aiooui: https://github.com/Bluetooth-Devices/aiooui

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

mac-vendor-lookup can take a long time to startup because
it has to fetch the oui db from the web
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested this on prod. and everything works 👍

@jpbede jpbede merged commit 93cc6e0 into dev Feb 26, 2024
53 checks passed
@jpbede jpbede deleted the nmap_load_time branch February 26, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants