Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an eager task to update multiple entities #111556

Merged
merged 1 commit into from Feb 27, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 26, 2024

Proposed change

If there are multiple entities on the same platform its likely that only one of them will suspend in the update so schedule them eagerly. Additionally we have lots of entities that never suspend in async_update, and its only a coro because its required to be to run in the event loop.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If there are multiple entities on the same platform its likely
that only one of them will suspend in the update so schedule
them eagerly
@bdraco bdraco marked this pull request as ready for review February 26, 2024 23:56
@bdraco bdraco requested a review from a team as a code owner February 26, 2024 23:56
@balloob balloob merged commit b75277c into dev Feb 27, 2024
53 checks passed
@balloob balloob deleted the eager_inner_async_update_ha_state branch February 27, 2024 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants