Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python_roborock to 0.40.0 #112238

Merged
merged 3 commits into from Mar 4, 2024

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Mar 4, 2024

Breaking change

Proposed change

I have been trying to diagnose some users issues for a while, but unfortunately, we create a random 16 byte string that we send to the Roborock servers, and then the responses come back encrypted by that. So without those bytes, I am unable to diagnose the users issues.

changes: humbertogontijo/python-roborock@v0.39.2...v0.40.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant home-assistant bot added integration: roborock small-pr PRs with less than 30 lines. labels Mar 4, 2024
@home-assistant home-assistant bot marked this pull request as draft March 4, 2024 14:13
@home-assistant
Copy link

home-assistant bot commented Mar 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Mar 4, 2024

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@Lash-L Lash-L marked this pull request as ready for review March 4, 2024 14:30
@Kane610
Copy link
Member

Kane610 commented Mar 4, 2024

Please add a version diff between the two versions of the library this PR is about

@Lash-L
Copy link
Contributor Author

Lash-L commented Mar 4, 2024

Please add a version diff between the two versions of the library this PR is about

oops, can't believe i forgot that. Fixed.

@jpbede jpbede added this to the 2024.3.0 milestone Mar 4, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lash-L 👍

@jpbede jpbede merged commit 59df20f into home-assistant:dev Mar 4, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants