Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weatherflow_cloud backing lib bump #112262

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Mar 4, 2024

Breaking change

Proposed change

I closed this ticket #112030 - however @bacco007 was still having an issue. He sent me his test data and we determined that a "required" field as-per API docs was not actually present on his end.

I made the field optional in the backing lib -> and bumped the version

jeeftor/weatherflow4py@v0.1.12...v0.1.13

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cgarwood cgarwood merged commit 7406ae3 into home-assistant:dev Mar 4, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
@frenck frenck added this to the 2024.3.1 milestone Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants