Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default code to alarm_control_panel #112540

Merged
merged 12 commits into from
May 29, 2024
Merged

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Mar 6, 2024

Proposed change

This adds setting a default code to alarm_control_oanel
Decided in home-assistant/architecture#892

Frontend PR: home-assistant/frontend#20062

Dev blog post: home-assistant/developers.home-assistant#2191

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 6, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (alarm_control_panel) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of alarm_control_panel can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign alarm_control_panel Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST gjohansson-ST force-pushed the alarm_control_panel-default-code branch 2 times, most recently from 213ec28 to e3e9f03 Compare March 22, 2024 20:01
@gjohansson-ST gjohansson-ST marked this pull request as draft April 22, 2024 18:27
@gjohansson-ST gjohansson-ST force-pushed the alarm_control_panel-default-code branch from e3e9f03 to 5f59e1d Compare April 22, 2024 18:36
@gjohansson-ST gjohansson-ST marked this pull request as ready for review April 22, 2024 19:06
@home-assistant home-assistant bot marked this pull request as draft April 24, 2024 15:22
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@gjohansson-ST gjohansson-ST reopened this May 12, 2024
@gjohansson-ST gjohansson-ST force-pushed the alarm_control_panel-default-code branch from d86eee7 to b4c0877 Compare May 14, 2024 15:54
homeassistant/components/alarm_control_panel/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/alarm_control_panel/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/alarm_control_panel/__init__.py Outdated Show resolved Hide resolved
@@ -53,6 +53,7 @@ class CanaryAlarm(
| AlarmControlPanelEntityFeature.ARM_AWAY
| AlarmControlPanelEntityFeature.ARM_NIGHT
)
_attr_code_arm_required = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These integrations doesn't require a code for their methods but was by not implementing code_arm_required actually setting it to True.
We are with this PR introducing validation for code so without setting this property to False these integrations would require a code input from the user.
See blog post link in the PR description.

@gjohansson-ST gjohansson-ST force-pushed the alarm_control_panel-default-code branch from b483a54 to 2d7fe46 Compare May 22, 2024 19:33
@gjohansson-ST gjohansson-ST marked this pull request as ready for review May 22, 2024 20:18
@home-assistant home-assistant bot requested a review from emontnemery May 22, 2024 20:19
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

@emontnemery
Copy link
Contributor

Can be merged when the frontend PR is approved

@frenck frenck added smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels May 25, 2024
@frenck frenck added this to the 2024.6.0b0 milestone May 25, 2024
@edenhaus edenhaus merged commit 6b7ff2b into dev May 29, 2024
38 checks passed
@edenhaus edenhaus deleted the alarm_control_panel-default-code branch May 29, 2024 08:46
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core integration: alarm_control_panel new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants