-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default code to alarm_control_panel #112540
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
a169093
to
a9a6002
Compare
213ec28
to
e3e9f03
Compare
e3e9f03
to
5f59e1d
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
d86eee7
to
b4c0877
Compare
@@ -53,6 +53,7 @@ class CanaryAlarm( | |||
| AlarmControlPanelEntityFeature.ARM_AWAY | |||
| AlarmControlPanelEntityFeature.ARM_NIGHT | |||
) | |||
_attr_code_arm_required = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These integrations doesn't require a code for their methods but was by not implementing code_arm_required
actually setting it to True
.
We are with this PR introducing validation for code so without setting this property to False
these integrations would require a code input from the user.
See blog post link in the PR description.
b483a54
to
2d7fe46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gjohansson-ST 👍
Can be merged when the frontend PR is approved |
Proposed change
This adds setting a default code to
alarm_control_oanel
Decided in home-assistant/architecture#892
Frontend PR: home-assistant/frontend#20062
Dev blog post: home-assistant/developers.home-assistant#2191
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: