Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pymodbus to v3.6.5 #112629

Merged
merged 1 commit into from Mar 7, 2024
Merged

Bump pymodbus to v3.6.5 #112629

merged 1 commit into from Mar 7, 2024

Conversation

janiversen
Copy link
Member

@janiversen janiversen commented Mar 7, 2024

Breaking change

Proposed change

Bump pymodbus to v3.6.5 (used by the modbus integration).

Changelog:

https://github.com/pymodbus-dev/pymodbus/blob/dev/CHANGELOG.rst

Release notes:

https://github.com/pymodbus-dev/pymodbus/releases/tag/v3.6.5

Seen from our usage it fixes a recurring log message, which fills the homeassistant log.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@janiversen
Copy link
Member Author

Thanks.

@janiversen janiversen merged commit 27af6f1 into home-assistant:dev Mar 7, 2024
53 checks passed
@janiversen janiversen deleted the bump branch March 7, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants